[webkit-changes] [WebKit/WebKit] c99552: [GTK][WPE] Add GWeakPtr to WTF and use it instead ...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c995526f428610fc057ab7c141f31cbe99a1e2cb
      https://github.com/WebKit/WebKit/commit/c995526f428610fc057ab7c141f31cbe99a1e2cb
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-01-27 (Fri, 27 Jan 2023)

  Changed paths:
    M Source/JavaScriptCore/API/glib/JSCException.cpp
    M Source/WTF/wtf/PlatformGTK.cmake
    M Source/WTF/wtf/PlatformWPE.cmake
    A Source/WTF/wtf/glib/GWeakPtr.h
    M Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp
    M Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.h
    M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h
    M Source/WebKit/UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp
    M Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp
    M Tools/TestWebKitAPI/PlatformGTK.cmake
    M Tools/TestWebKitAPI/PlatformWPE.cmake
    A Tools/TestWebKitAPI/Tests/WTF/glib/GWeakPtr.cpp

  Log Message:
  -----------
  [GTK][WPE] Add GWeakPtr to WTF and use it instead of explicit g_object_add|remove_weak_pointer
https://bugs.webkit.org/show_bug.cgi?id=251258

Reviewed by Michael Catanzaro and Adrian Perez de Castro.

It's very common to forget to remove a weak references, GWeakPtr ensures
weak references are always removed and makes easier to create weak
GObjects.

* Source/WTF/wtf/PlatformGTK.cmake:
* Source/WTF/wtf/PlatformWPE.cmake:
* Source/WTF/wtf/glib/GWeakPtr.h: Added.
(WTF::GWeakPtr::GWeakPtr):
(WTF::GWeakPtr::~GWeakPtr):
(WTF::GWeakPtr::get const):
(WTF::GWeakPtr::reset):
* Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp:
(webkitDownloadCreate):
(webkit_download_get_web_view):
(_WebKitDownloadPrivate::~_WebKitDownloadPrivate): Deleted.
* Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp:
(webkitFaviconDatabaseGetLoadDecisionForIcon):
* Source/WebKit/UIProcess/API/glib/WebKitIconLoadingClient.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp:
(UIClient::~UIClient): Deleted.
* Tools/TestWebKitAPI/PlatformGTK.cmake:
* Tools/TestWebKitAPI/PlatformWPE.cmake:
* Tools/TestWebKitAPI/Tests/WTF/glib/GWeakPtr.cpp: Added.
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/259482@main