[webkit-changes] [WebKit/WebKit] 86dd3d: [GTK][WPE] WebsiteDataManger created by persistent...

Carlos Garcia Campos noreply at github.com
Fri Jan 27 05:22:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86dd3d71686a925f890f8fbadbf818be7f05dedf
      https://github.com/WebKit/WebKit/commit/86dd3d71686a925f890f8fbadbf818be7f05dedf
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-01-27 (Fri, 27 Jan 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManagerPrivate.h
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
    M Source/WebKit/UIProcess/glib/WebsiteDataStoreGLib.cpp
    M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp

  Log Message:
  -----------
  [GTK][WPE] WebsiteDataManger created by persistent network session should never return NULL for base cache and data directories
https://bugs.webkit.org/show_bug.cgi?id=251255

Reviewed by Adrian Perez de Castro.

When NULL is passed to network session constructor the default directory
is provided to website data manager to ensure the getters don't return
NULL.

* Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp:
(webkitNetworkSessionSetProperty):
(webkitNetworkSessionConstructed):
* Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
(webkitWebsiteDataManagerSetProperty):
(webkitWebsiteDataManagerConstructed):
(webkitWebsiteDataManagerGetDataStore):
(webkitWebsiteDataManagerCreate):
(webkit_website_data_manager_get_base_data_directory):
(webkit_website_data_manager_get_base_cache_directory):
(webkitWebsiteDataManagerGetFaviconDatabasePath):
* Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManagerPrivate.h:
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
* Source/WebKit/UIProcess/glib/WebsiteDataStoreGLib.cpp:
(WebKit::WebsiteDataStore::defaultBaseCacheDirectory):
(WebKit::WebsiteDataStore::defaultBaseDataDirectory):
(WebKit::WebsiteDataStore::cacheDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataConfiguration):

Canonical link: https://commits.webkit.org/259480@main




More information about the webkit-changes mailing list