[webkit-changes] [WebKit/WebKit] b6bf0e: [WK2] Remove WantsConnection IPC message attribute

[Žan Doberšek]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6bf0e666f01ea3b00004e6d666d00261dbdc655
      https://github.com/WebKit/WebKit/commit/b6bf0e666f01ea3b00004e6d666d00261dbdc655
  Author: Žan Doberšek <zdobersek at igalia.com>
  Date:   2023-01-27 (Fri, 27 Jan 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkBroadcastChannelRegistry.messages.in
    M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.messages.in
    M Source/WebKit/Platform/IPC/HandleMessage.h
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Scripts/webkit/model.py
    M Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiver.messages.in
    M Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp
    M Source/WebKit/Scripts/webkit/tests/TestWithSuperclass.messages.in
    M Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessageReceiver.cpp
    M Source/WebKit/Scripts/webkit/tests/TestWithoutAttributes.messages.in
    M Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp
    M Source/WebKit/Shared/IPCTester.messages.in
    M Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.messages.in
    M Source/WebKit/UIProcess/WebGeolocationManagerProxy.messages.in
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/UIProcess/WebPasteboardProxy.messages.in
    M Source/WebKit/UIProcess/WebProcessPool.messages.in

  Log Message:
  -----------
  [WK2] Remove WantsConnection IPC message attribute
https://bugs.webkit.org/show_bug.cgi?id=251030

Reviewed by Kimmo Kinnunen.

The 'WantsConnection' IPC message attribute imposed using the wants-connection
variants of IPC::handleMessage(), passing the Connection reference as the first
argument to the method handling a given IPC message.

The attribute can be removed, along with the relevant IPC::handleMessage()
variants. Instead, the initial Connection reference parameter on the handler
method can be indicated on the MethodSignatureValidation template class that's
already used for validation purposes. Existing variants do a constexpr check and
adjust the method invocation to pass the Connection reference as the first
argument to the method when necessary.

* Source/WebKit/NetworkProcess/NetworkBroadcastChannelRegistry.messages.in:
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.messages.in:
* Source/WebKit/Platform/IPC/HandleMessage.h:
(IPC::handleMessage):
(IPC::handleMessageSynchronous):
(IPC::handleMessageAsync):
(IPC::handleMessageWantsConnection): Deleted.
(IPC::handleMessageSynchronousWantsConnection): Deleted.
(IPC::handleMessageAsyncWantsConnection): Deleted.
* Source/WebKit/Scripts/webkit/messages.py:
(async_message_statement):
(sync_message_statement):
* Source/WebKit/Scripts/webkit/model.py:
* Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiver.messages.in:
* Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp:
(WebKit::TestWithLegacyReceiver::didReceiveSyncTestWithLegacyReceiverMessage):
* Source/WebKit/Scripts/webkit/tests/TestWithSuperclass.messages.in:
* Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessageReceiver.cpp:
(WebKit::TestWithSuperclass::didReceiveMessage):
* Source/WebKit/Scripts/webkit/tests/TestWithoutAttributes.messages.in:
* Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp:
(WebKit::TestWithoutAttributes::didReceiveSyncMessage):
* Source/WebKit/Shared/IPCTester.messages.in:
* Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.messages.in:
* Source/WebKit/UIProcess/WebGeolocationManagerProxy.messages.in:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/WebPasteboardProxy.messages.in:
* Source/WebKit/UIProcess/WebProcessPool.messages.in:

Canonical link: https://commits.webkit.org/259476@main