[webkit-changes] [WebKit/WebKit] e336cd: CacheStorageCache should only read record informat...
Sihui
noreply at github.com
Thu Jan 26 19:51:13 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e336cd312522197d529e20885f684c35c09d62f9
https://github.com/WebKit/WebKit/commit/e336cd312522197d529e20885f684c35c09d62f9
Author: Sihui Liu <sihui_liu at apple.com>
Date: 2023-01-26 (Thu, 26 Jan 2023)
Changed paths:
M Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp
M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp
M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.h
M Source/WebKit/NetworkProcess/storage/CacheStorageMemoryStore.cpp
M Source/WebKit/NetworkProcess/storage/CacheStorageMemoryStore.h
M Source/WebKit/NetworkProcess/storage/CacheStorageStore.h
Log Message:
-----------
CacheStorageCache should only read record information instead of full record when possible
https://bugs.webkit.org/show_bug.cgi?id=251213
rdar://104696982
Reviewed by Youenn Fablet.
Reading a full record, which might include reading record body from disk, decoding record body and computing body hash,
can be more expensive than reading just record information, so we should avoid it if not necessary.
* Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp:
(WebKit::CacheStorageCache::getSize):
(WebKit::CacheStorageCache::open):
* Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp:
(WebKit::readRecordInfoFromFileData):
(WebKit::CacheStorageDiskStore::readRecordFromFileData):
(WebKit::CacheStorageDiskStore::readAllRecordInfos):
(WebKit::CacheStorageDiskStore::readAllRecords): Deleted.
* Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.h:
* Source/WebKit/NetworkProcess/storage/CacheStorageMemoryStore.cpp:
(WebKit::CacheStorageMemoryStore::readAllRecordInfos):
(WebKit::CacheStorageMemoryStore::readAllRecords): Deleted.
* Source/WebKit/NetworkProcess/storage/CacheStorageMemoryStore.h:
* Source/WebKit/NetworkProcess/storage/CacheStorageStore.h:
Canonical link: https://commits.webkit.org/259463@main
More information about the webkit-changes
mailing list