[webkit-changes] [WebKit/WebKit] 6361a6: Unexpected overlapping selection with tab in RTL c...

Alan Baradlay noreply at github.com
Thu Jan 26 16:53:17 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6361a69741b71e160fa9b6d9d205168018594ded
      https://github.com/WebKit/WebKit/commit/6361a69741b71e160fa9b6d9d205168018594ded
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-01-26 (Thu, 26 Jan 2023)

  Changed paths:
    A LayoutTests/fast/repaint/rtl-with-position-dependent-content-width-selection-expected.txt
    A LayoutTests/fast/repaint/rtl-with-position-dependent-content-width-selection.html
    M Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h

  Log Message:
  -----------
  Unexpected overlapping selection with tab in RTL context.
https://bugs.webkit.org/show_bug.cgi?id=251169

Reviewed by Antti Koivisto.

In order to get the correct advanced width at selection paint time we need to pass in the "logical horizontal position" (the value we used at layout).

* LayoutTests/fast/repaint/rtl-with-position-dependent-content-width-selection-expected.txt: Added.
* LayoutTests/fast/repaint/rtl-with-position-dependent-content-width-selection.html: Added.
* Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h:
(WebCore::InlineIterator::BoxModernPath::textRun const):

Canonical link: https://commits.webkit.org/259460@main




More information about the webkit-changes mailing list