[webkit-changes] [WebKit/WebKit] 0f58ae: Restrict the set of defaults-overridable flags to ...

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f58ae8a9cfeded106727881a403f817a692d8f4
      https://github.com/WebKit/WebKit/commit/0f58ae8a9cfeded106727881a403f817a692d8f4
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2023-01-26 (Thu, 26 Jan 2023)

  Changed paths:
    M Source/WTF/Scripts/GeneratePreferences.rb
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb
    M Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm

  Log Message:
  -----------
  Restrict the set of defaults-overridable flags to better match shipping Safari
https://bugs.webkit.org/show_bug.cgi?id=251183
<rdar://104657361>

Reviewed by Elliott Williams.

The new feature generator logic attempts to persist all `internal` feature flags such
that a developer can use a 'WebKitDebug'-prefix for a setting to override it. This is
only desired for a small set of feature flags (those that lived in the
Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml file previously).

This patch does the following:

1. Corrects a handful of feature flags that were moved from `internal` to `embedder`, improperly.
2. Adds a new key, `defaultsOverridable`, to UnifiedWebPreferences.yaml. Flags that
have this key with a `true` value will get additional logic to support
'WebKitDebug'-prefix overrides.
3. Changes the predicate from 'defaultOverridable?' to `defaultsOverridable?' for consistency.
4. Partial revert of 258448 at main to restore the ability to honor debug overrides for UInt32 types.

* Source/WTF/Scripts/GeneratePreferences.rb:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb:
* Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm:
(WebKit::setDebugUInt32ValueIfInUserDefaults): Partial revert of 258448 at main. We actually
do need this method.

Canonical link: https://commits.webkit.org/259458@main