[webkit-changes] [WebKit/WebKit] f1b160: [IFC] Rename InlineDisplay::Line::contentVisualOff...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1b16009440db8589015ae62c5349a2811cd80c8
      https://github.com/WebKit/WebKit/commit/f1b16009440db8589015ae62c5349a2811cd80c8
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-01-26 (Thu, 26 Jan 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp
    M Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h
    M Source/WebCore/layout/integration/inline/InlineIteratorLineBoxModernPath.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLine.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp

  Log Message:
  -----------
  [IFC] Rename InlineDisplay::Line::contentVisualOffsetInInlineDirection to contentLogicalLeftIgnoringInlineDirection
https://bugs.webkit.org/show_bug.cgi?id=251210

Reviewed by Antti Koivisto.

This value represents the content (root inline box) offset from the line box. It's mostly 0 but in certain cases like text-align,
the content is not necessarily in flush with the line box.
The "logical" prefix and "ignoringInlineDirection" postfix follows the iterator naming convention where "logical" means not applying writing mode
while "ignoringInlineDirection" means treat this value as if the inline direction was left-to-right (i.e. in case of "writing-mode: horizontal-tb", and regardless of "dir" value, this is the visual left, but we can't use the "visual" prefix here).

This patch also adds the "true" logical content offset as preparation for fixing tab width computation at painting time.

* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h:
(WebCore::InlineDisplay::Line::contentLogicalLeft const):
(WebCore::InlineDisplay::Line::contentLogicalLeftIgnoringInlineDirection const):
(WebCore::InlineDisplay::Line::Line):
(WebCore::InlineDisplay::Line::contentVisualOffsetInInlineDirection const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:
(WebCore::Layout::InlineDisplayLineBuilder::build const):
* Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h:
(WebCore::InlineIterator::BoxModernPath::textRun const):
* Source/WebCore/layout/integration/inline/InlineIteratorLineBoxModernPath.h:
(WebCore::InlineIterator::LineBoxIteratorModernPath::contentLogicalLeft const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLine.h:
(WebCore::LayoutIntegration::Line::Line):
(WebCore::LayoutIntegration::Line::contentLogicalLeft const):
(WebCore::LayoutIntegration::Line::contentLogicalLeftIgnoringInlineDirection const):
(WebCore::LayoutIntegration::Line::contentVisualOffsetInInlineDirection const): Deleted.
* Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp:
(WebCore::LayoutIntegration::makeAdjustedContent):

Canonical link: https://commits.webkit.org/259443@main