[webkit-changes] [WebKit/WebKit] 9b7933: [ews-build.webkit.org] Use Twisted defer for revie...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b7933872a4ab7bc6617fd8b7ecd700331ac877a
      https://github.com/WebKit/WebKit/commit/9b7933872a4ab7bc6617fd8b7ecd700331ac877a
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-01-26 (Thu, 26 Jan 2023)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [ews-build.webkit.org] Use Twisted defer for reviewer queries
https://bugs.webkit.org/show_bug.cgi?id=250765
rdar://104382329

Reviewed by Aakash Jain.

Replace fetch_data_from_url_with_authentication_github with a Twisted
version of the same function, but keep around the old function while
we transition. Adopt the Twisted version of the function when listing
reviewers of a PR.

* Tools/CISupport/ews-build/steps.py:
(GitHubMixin):
(GitHubMixin.fetch_data_from_url_with_authentication_github): Convert to Twisted.
(GitHubMixin.fetch_data_from_url_with_authentication_github_old): Retain old
synchronous version.
(GitHubMixin.get_pr_json): Use old synchronous version.
(GitHubMixin.get_reviewers): Use new Twisted version.
(GitHubMixin.remove_labels): Use old synchronous version.
(ValidateCommitterAndReviewer.run): Use Twisted asynchronous requests.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestGitHubMixin.test_no_reviewers): Return defered to match API we're mocking.
(TestGitHubMixin.test_single_review): Ditto.
(TestGitHubMixin.test_multipe_reviews): Ditto.
(TestGitHubMixin.test_retracted_review): Ditto.
(TestGitHubMixin.test_pagination): Ditto.
(TestGitHubMixin.test_reviewers_invalid_response): Ditto.
(TestGitHubMixin.test_reviewers_error): Ditto.

Canonical link: https://commits.webkit.org/259427@main