[webkit-changes] [WebKit/WebKit] 87f97d: Cherry-pick 252432.943 at safari-7614-branch (c624901...

EWS noreply at github.com
Thu Jan 26 08:28:32 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87f97d83b3c9f1c5dffc192a0611240110cb6175
      https://github.com/WebKit/WebKit/commit/87f97d83b3c9f1c5dffc192a0611240110cb6175
  Author: Angela Izquierdo Garcia <a_izquierdogarcia at apple.com>
  Date:   2023-01-26 (Thu, 26 Jan 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.h

  Log Message:
  -----------
  Cherry-pick 252432.943 at safari-7614-branch (c6249012752b). rdar://104655527

    Floating Point Exception in FEConvolveMatrixSoftwareApplier:: applyPatform
    https://bugs.webkit.org/show_bug.cgi?id=248288
    rdar://102137760

    There is a division by zero due to the fact that sometimes there is one variable much bigger than other that are implied in a division (clipBottom and iterations) and as c++ rounds down it is consequently zero, which leads to the subsequent exception.

    Reviewed by Geoffrey Garen and David Kilzer.

    * Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.cpp:
    (WebCore::FEConvolveMatrixSoftwareApplier::setInteriorPixels):
    (WebCore::FEConvolveMatrixSoftwareApplier::applyPlatform const):
    * Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.h:

    Canonical link: https://commits.webkit.org/252432.943@safari-7614-branch

Canonical link: https://commits.webkit.org/259424@main




More information about the webkit-changes mailing list