[webkit-changes] [WebKit/WebKit] 7c77ae: Disconnected <fieldset> elements sometimes incorre...
EWS
noreply at github.com
Thu Jan 26 07:45:23 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7c77ae89409598c580a9d814b12d21a6cf71a31c
https://github.com/WebKit/WebKit/commit/7c77ae89409598c580a9d814b12d21a6cf71a31c
Author: Alexey Shvayka <ashvayka at apple.com>
Date: 2023-01-26 (Thu, 26 Jan 2023)
Changed paths:
A LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid-fieldset-disconnected-expected.txt
A LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid-fieldset-disconnected.html
M Source/WebCore/html/ValidatedFormListedElement.cpp
Log Message:
-----------
Disconnected <fieldset> elements sometimes incorrectly match :valid / :invalid selectors
https://bugs.webkit.org/show_bug.cgi?id=250936
Reviewed by Ryosuke Niwa.
This change removes isConnected() checks from updateValidity() so that form controls in disconnected
subtrees update validity status of their <fieldset> ancestors, like they do for form owners,
aligning WebKit with the spec [1], Blink, and Gecko.
[1] https://html.spec.whatwg.org/multipage/semantics-other.html#selector-valid (no connected-ness check)
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid-fieldset-disconnected-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid-fieldset-disconnected.html: Added.
* Source/WebCore/html/ValidatedFormListedElement.cpp:
(WebCore::ValidatedFormListedElement::updateValidity):
Canonical link: https://commits.webkit.org/259422@main
More information about the webkit-changes
mailing list