[webkit-changes] [WebKit/WebKit] 865cbc: Solidus stripping in DOMURL::setHostname seems wrong

Chris Dumez noreply at github.com
Wed Jan 25 09:26:40 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 865cbc8abfc520b04889af320a289f66905733a1
      https://github.com/WebKit/WebKit/commit/865cbc8abfc520b04889af320a289f66905733a1
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-01-25 (Wed, 25 Jan 2023)

  Changed paths:
    M LayoutTests/fast/dom/DOMURL/set-href-attribute-hostname-expected.txt
    M LayoutTests/fast/dom/DOMURL/set-href-attribute-hostname.html
    M LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt
    M LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
    M LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker-expected.txt
    M Source/WebCore/html/URLDecomposition.cpp

  Log Message:
  -----------
  Solidus stripping in DOMURL::setHostname seems wrong
https://bugs.webkit.org/show_bug.cgi?id=127970

Reviewed by Youenn Fablet.

Stop stripping solidus from input in URL.hostname setter.
This doesn't match the behavior of Blink or Gecko.

* LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any-expected.txt:
* Source/WebCore/html/URLDecomposition.cpp:
(WebCore::URLDecomposition::setHostname):
(WebCore::removeAllLeadingSolidusCharacters): Deleted.

Canonical link: https://commits.webkit.org/259366@main




More information about the webkit-changes mailing list