[webkit-changes] [WebKit/WebKit] c58b32: Web Inspector: Fonts Panel: ITAL variation axis sl...

Razvan Caliman - Apple noreply at github.com
Wed Jan 25 07:03:07 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c58b326609c90f5e3f07a21a6e2dce4dfd112904
      https://github.com/WebKit/WebKit/commit/c58b326609c90f5e3f07a21a6e2dce4dfd112904
  Author: Razvan Caliman <rcaliman at apple.com>
  Date:   2023-01-25 (Wed, 25 Jan 2023)

  Changed paths:
    A LayoutTests/inspector/model/font-styles-conversion-expected.txt
    A LayoutTests/inspector/model/font-styles-conversion.html
    M Source/WebInspectorUI/UserInterface/Models/FontStyles.js
    M Source/WebInspectorUI/UserInterface/Views/FontVariationDetailsSectionRow.js

  Log Message:
  -----------
  Web Inspector: Fonts Panel: ITAL variation axis slider has value of NaN
https://bugs.webkit.org/show_bug.cgi?id=250906

Reviewed by Patrick Angle.

The value of the `font-style` CSS property maps to either
`ITAL` or `SLNT` font variation axes when available.

`font-style: normal` should equate to `ITAL: 0`.
This case wasn't handled for the `ITAL` axis.

* LayoutTests/inspector/model/font-styles-conversion-expected.txt: Added.
* LayoutTests/inspector/model/font-styles-conversion.html: Added.
* Source/WebInspectorUI/UserInterface/Models/FontStyles.js:
(WI.FontStyles.axisValueToFontPropertyValue):
(WI.FontStyles.fontPropertyValueToAxisValue):
* Source/WebInspectorUI/UserInterface/Views/FontVariationDetailsSectionRow.js:
(WI.FontVariationDetailsSectionRow):
(WI.FontVariationDetailsSectionRow.prototype._getAxisResolution):

Canonical link: https://commits.webkit.org/259351@main




More information about the webkit-changes mailing list