[webkit-changes] [WebKit/WebKit] f10f7a: [WGSL] Add support for multiplication

Tadeu Zagallo noreply at github.com
Wed Jan 25 03:33:51 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f10f7a628c8aa99d35b120c1a84f0cf519072c42
      https://github.com/WebKit/WebKit/commit/f10f7a628c8aa99d35b120c1a84f0cf519072c42
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-01-25 (Wed, 25 Jan 2023)

  Changed paths:
    M Source/WebGPU/WGSL/AST/ASTBinaryExpression.h
    M Source/WebGPU/WGSL/AST/ASTStringDumper.cpp
    M Source/WebGPU/WGSL/Lexer.cpp
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/Parser.cpp
    M Source/WebGPU/WGSL/Token.cpp
    M Source/WebGPU/WGSL/Token.h

  Log Message:
  -----------
  [WGSL] Add support for multiplication
https://bugs.webkit.org/show_bug.cgi?id=251088
<rdar://problem/104600637>

Reviewed by Myles C. Maxfield and Dean Jackson.

As the title says: add parsing and a new BinaryOperation for multiplication.
The lexing will have to change as we add support for comments and other operators,
but this will do for now and enables testing more complex shaders.

* Source/WebGPU/WGSL/AST/ASTBinaryExpression.h:
* Source/WebGPU/WGSL/AST/ASTStringDumper.cpp:
(WGSL::AST::StringDumper::visit):
* Source/WebGPU/WGSL/Lexer.cpp:
(WGSL::Lexer<T>::lex):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseMultiplicativeExpression):
* Source/WebGPU/WGSL/Token.cpp:
(WGSL::toString):
* Source/WebGPU/WGSL/Token.h:

Canonical link: https://commits.webkit.org/259347@main




More information about the webkit-changes mailing list