[webkit-changes] [WebKit/WebKit] d9da70: HLS videos sometimes fail to reach "ended" state &...
Jer Noble
noreply at github.com
Tue Jan 24 23:35:20 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d9da700801d7af287ce3ad9500da44f4a7feec96
https://github.com/WebKit/WebKit/commit/d9da700801d7af287ce3ad9500da44f4a7feec96
Author: Jer Noble <jer.noble at apple.com>
Date: 2023-01-24 (Tue, 24 Jan 2023)
Changed paths:
A LayoutTests/http/tests/media/hls/hls-ended-expected.txt
A LayoutTests/http/tests/media/hls/hls-ended.html
M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Log Message:
-----------
HLS videos sometimes fail to reach "ended" state & cannot be restarted
https://bugs.webkit.org/show_bug.cgi?id=251119
rdar://102114139
Reviewed by Eric Carlson.
When WebKit receives the AVPlayerItemDidPlayToEndTimeNotification notification, it still
attempts to estimate the current time because it believes it is still playing, as it hasn't
yet received the -timeControlStatus KVO. Reset the values for currentTime estimation when
receiving this notification so that the values returned are consistent.
* LayoutTests/http/tests/media/hls/hls-ended-expected.txt: Added.
* LayoutTests/http/tests/media/hls/hls-ended.html: Added.
* Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::didEnd):
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::didEnd):
Canonical link: https://commits.webkit.org/259342@main
More information about the webkit-changes
mailing list