[webkit-changes] [WebKit/WebKit] d7b129: AX: Use stronger typing of AccessibilityObject in ...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7b129acb04cbcb1d943ed6cc46379062ab819a2
      https://github.com/WebKit/WebKit/commit/d7b129acb04cbcb1d943ed6cc46379062ab819a2
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  -----------
  AX: Use stronger typing of AccessibilityObject in AXObjectCache, AXIsolatedObject, and AXIsolatedTree
https://bugs.webkit.org/show_bug.cgi?id=251057
rdar://problem/104582945

Reviewed by Chris Fleizach.

There are a bunch of places where we pass an AXCoreObject and immediately ASSERT(is<AccessibilityObject>(object)).
We should just use stronger types, which avoids asserts and casting, and possibly helps the compiler perform
de-virtualization optimizations.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::AXIsolatedObject):
(WebCore::AXIsolatedObject::create):
(WebCore::AXIsolatedObject::initializeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::generateSubtree):
(WebCore::AXIsolatedTree::nodeChangeForObject):
(WebCore::AXIsolatedTree::updateNode):
(WebCore::AXIsolatedTree::updatePropertiesForSelfAndDescendants):
(WebCore::AXIsolatedTree::updateNodeAndDependentProperties):
(WebCore::AXIsolatedTree::removeNode):
(WebCore::AXIsolatedTree::removeSubtreeFromNodeMap):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/259334@main