[webkit-changes] [WebKit/WebKit] 212955: Web Inspector: Screenshots timeline is unsupported...

Patrick Angle noreply at github.com
Tue Jan 24 18:16:06 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2129556ec693c9909c60b6576f8a1c08c9f03a4d
      https://github.com/WebKit/WebKit/commit/2129556ec693c9909c60b6576f8a1c08c9f03a4d
  Author: Patrick Angle <pangle at apple.com>
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebInspectorUI/UserInterface/Models/ScreenshotsInstrument.js

  Log Message:
  -----------
  Web Inspector: Screenshots timeline is unsupported in WebKitLegacy, we should disable it when inspect such targets
https://bugs.webkit.org/show_bug.cgi?id=244301
rdar://problem/99094864

Reviewed by Devin Rousso and BJ Burg.

Screenshots are taken when a composite occurs to populate the screenshots timeline. Composites do not occurs for
the same types of updates in WebKitLegacy as they do in WebKit2. Due to this, the timeline currently appears
broken on WebKitLegacy targets. Until we can do the work in webkit.org/b/251113 to support WebKitLegacy, we
instead will disable the Screenshots timeline when inspecting WebKitLegacy targets (the "Page" debuggable type,
as opposed to the WK2 "Web Page" debuggable type).

* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebInspectorUI/UserInterface/Models/ScreenshotsInstrument.js:
(WI.ScreenshotsInstrument.supported):

Canonical link: https://commits.webkit.org/259326@main




More information about the webkit-changes mailing list