[webkit-changes] [WebKit/WebKit] 7a1613: REGRESSION (255063 at main): visibility:visible child...

Alan Baradlay noreply at github.com
Tue Jan 24 13:02:19 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a1613fa8b157e2deffe4b253d9d211a44c942a3
      https://github.com/WebKit/WebKit/commit/7a1613fa8b157e2deffe4b253d9d211a44c942a3
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
    A LayoutTests/fast/block/paint-non-visible-with-visible-child-expected.html
    A LayoutTests/fast/block/paint-non-visible-with-visible-child.html
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp

  Log Message:
  -----------
  REGRESSION (255063 at main): visibility:visible child of visibility:hidden button remains invisible
https://bugs.webkit.org/show_bug.cgi?id=251000
<rdar://problem/104565584>

Reviewed by Antti Koivisto and Darin Adler.

Let's not bail out of painting too early for "visibility: hidden". Such inline-block (and inline-block like) boxes may have visible descendants.

* LayoutTests/fast/block/paint-non-visible-with-visible-child-expected.html: Added.
* LayoutTests/fast/block/paint-non-visible-with-visible-child.html: Added.
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:
(WebCore::LayoutIntegration::InlineContentPainter::paintDisplayBox):

Canonical link: https://commits.webkit.org/259306@main




More information about the webkit-changes mailing list