[webkit-changes] [WebKit/WebKit] 0b02c2: GamepadManager should use WeakHashMap instead of H...
Ryosuke Niwa
noreply at github.com
Tue Jan 24 12:10:22 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0b02c29900705e60f0f8f6acbe01158e1126e086
https://github.com/WebKit/WebKit/commit/0b02c29900705e60f0f8f6acbe01158e1126e086
Author: Ryosuke Niwa <rniwa at webkit.org>
Date: 2023-01-24 (Tue, 24 Jan 2023)
Changed paths:
M Source/WebCore/Modules/gamepad/GamepadManager.cpp
M Source/WebCore/Modules/gamepad/GamepadManager.h
M Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp
M Source/WebCore/Modules/gamepad/NavigatorGamepad.h
M Source/WebCore/page/DOMWindow.cpp
Log Message:
-----------
GamepadManager should use WeakHashMap instead of HashMap of raw pointers
https://bugs.webkit.org/show_bug.cgi?id=251072
Reviewed by Chris Dumez.
Use WeakHashMap instead of HashMap of raw pointers in GamepadManager.
* Source/WebCore/Modules/gamepad/GamepadManager.cpp:
(WebCore::navigatorGamepadFromDOMWindow):
(WebCore::GamepadManager::platformGamepadDisconnected):
(WebCore::GamepadManager::platformGamepadInputActivity):
(WebCore::GamepadManager::makeGamepadVisible):
(WebCore::GamepadManager::registerNavigator):
(WebCore::GamepadManager::unregisterNavigator):
(WebCore::GamepadManager::registerDOMWindow):
(WebCore::GamepadManager::unregisterDOMWindow):
(WebCore::GamepadManager::maybeStartMonitoringGamepads):
(WebCore::GamepadManager::maybeStopMonitoringGamepads):
* Source/WebCore/Modules/gamepad/GamepadManager.h:
* Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::NavigatorGamepad):
(WebCore::NavigatorGamepad::~NavigatorGamepad):
* Source/WebCore/Modules/gamepad/NavigatorGamepad.h:
* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::incrementGamepadEventListenerCount):
(WebCore::DOMWindow::decrementGamepadEventListenerCount):
Canonical link: https://commits.webkit.org/259301@main
More information about the webkit-changes
mailing list