[webkit-changes] [WebKit/WebKit] 1dc698: [@property] Container units are not computationall...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1dc6982298becf494b1554dec68a850533aa7d6b
      https://github.com/WebKit/WebKit/commit/1dc6982298becf494b1554dec68a850533aa7d6b
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
    A LayoutTests/fast/css/custom-properties/at-property-cqi-crash-expected.txt
    A LayoutTests/fast/css/custom-properties/at-property-cqi-crash.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-computational-independence-expected.txt
    M Source/WebCore/css/CSSPrimitiveValue.cpp
    M Source/WebCore/css/CSSValue.h

  Log Message:
  -----------
  [@property] Container units are not computationally independent
https://bugs.webkit.org/show_bug.cgi?id=251084
rdar://104550943

Reviewed by Alan Baradlay.

They depend on container dimensions and so should not be allowed in initial-value descriptors.

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-computational-independence-expected.txt:
* LayoutTests/fast/css/custom-properties/at-property-cqi-crash-expected.txt: Added.
* LayoutTests/fast/css/custom-properties/at-property-cqi-crash.html: Added.
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::collectComputedStyleDependencies const):

Set a bit indicating there are container dimension dependencies.

* Source/WebCore/css/CSSValue.h:
(WebCore::ComputedStyleDependencies::isEmpty const):

Canonical link: https://commits.webkit.org/259298@main