[webkit-changes] [WebKit/WebKit] 1153af: [GStreamer] Fix a crash for fast/speechsynthesis/s...
ChangSeok Oh
noreply at github.com
Tue Jan 24 00:24:26 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1153afca6d716b3bc6685e910d1b48fc7b5ba73c
https://github.com/WebKit/WebKit/commit/1153afca6d716b3bc6685e910d1b48fc7b5ba73c
Author: ChangSeok Oh <changseok at webkit.org>
Date: 2023-01-24 (Tue, 24 Jan 2023)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp
M Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp
M Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.h
Log Message:
-----------
[GStreamer] Fix a crash for fast/speechsynthesis/speech-synthesis-real-client-version.html
https://bugs.webkit.org/show_bug.cgi?id=251056
Reviewed by Xabier Rodriguez-Calvar.
The crash happens when the web content does not specify a voice to use. We handle a null pointer
of the voice with the default voice.
Test: fast/speechsynthesis/speech-synthesis-real-client-version.html
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp:
(WebCore::GstSpeechSynthesisWrapper::speakUtterance):
* Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp:
(fliteVoice):
(webKitFliteSrcSetUtterance):
* Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.h:
Canonical link: https://commits.webkit.org/259265@main
More information about the webkit-changes
mailing list