[webkit-changes] [WebKit/WebKit] 637ee2: Fix crash due to overflow when calculating area

EWS noreply at github.com
Mon Jan 23 17:11:21 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 637ee2cbc292f7e56a688f0fac932cab9a61dba1
      https://github.com/WebKit/WebKit/commit/637ee2cbc292f7e56a688f0fac932cab9a61dba1
  Author: Chirag M Shah <chirags2793 at gmail.com>
  Date:   2023-01-23 (Mon, 23 Jan 2023)

  Changed paths:
    A LayoutTests/fast/text/text-selection-direction-overflow-crash-expected.txt
    A LayoutTests/fast/text/text-selection-direction-overflow-crash.html
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm

  Log Message:
  -----------
  Fix crash due to overflow when calculating area
https://bugs.webkit.org/show_bug.cgi?id=250918
rdar://104479890

Reviewed by David Kilzer.

The code in getEvasionRectsAroundSelection already has the logic to deal
with overflows, so we shoudn't crash in that case, and let the code
proceed to do the right thing.

* LayoutTests/fast/text/text-selection-direction-overflow-crash-expected.txt: Added.
* LayoutTests/fast/text/text-selection-direction-overflow-crash.html: Added.
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::getEvasionRectsAroundSelection const):

Canonical link: https://commits.webkit.org/259254@main




More information about the webkit-changes mailing list