[webkit-changes] [WebKit/WebKit] e73104: [WebGPU] Fix assertion when loading textured-cube-...

Myles C. Maxfield noreply at github.com
Mon Jan 23 14:16:37 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e73104b88d62323b0bfadac557b3911561513a05
      https://github.com/WebKit/WebKit/commit/e73104b88d62323b0bfadac557b3911561513a05
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-01-23 (Mon, 23 Jan 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] Fix assertion when loading textured-cube-shader-constants.html
https://bugs.webkit.org/show_bug.cgi?id=250956
rdar://104517995

Reviewed by Tadeu Zagallo.

The assertion says:

-[MTLDebugDevice newDepthStencilStateWithDescriptor:]:929: failed assertion `descriptor must not be nil.'

So let's avoid calling that function if it's nil.

* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):

Canonical link: https://commits.webkit.org/259241@main




More information about the webkit-changes mailing list