[webkit-changes] [WebKit/WebKit] db1acf: [WebGPU] Give a ConvertToBackingContext to Surface...

Myles C. Maxfield noreply at github.com
Mon Jan 23 13:20:01 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db1acf95baa0e9acf5deb029a23c9baccd2460d3
      https://github.com/WebKit/WebKit/commit/db1acf95baa0e9acf5deb029a23c9baccd2460d3
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-01-23 (Mon, 23 Jan 2023)

  Changed paths:
    M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp
    M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSurfaceImpl.cpp
    M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSurfaceImpl.h
    M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSwapChainImpl.cpp
    M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSwapChainImpl.h

  Log Message:
  -----------
  [WebGPU] Give a ConvertToBackingContext to SurfaceImpl and SwapChainImpl
https://bugs.webkit.org/show_bug.cgi?id=250964
rdar://104522936

Reviewed by Kimmo Kinnunen.

SurfaceImpl and SwapChainImpl don't actually need a ConvertToBackingContext right now, but
most of the other ***Impl classes need one and have one, so I think it's just generally a
good idea to be consistent with the pattern and give one to all the ***Impl classes. In the
future, when we're developing, I don't think we should have to remember which classes have
a ConvertToBackingContext and which don't.

* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSurfaceImpl.cpp:
(PAL::WebGPU::SurfaceImpl::SurfaceImpl):
(PAL::WebGPU::SurfaceImpl::setLabelInternal):
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSurfaceImpl.h:
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSwapChainImpl.cpp:
(PAL::WebGPU::SwapChainImpl::SwapChainImpl):
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSwapChainImpl.h:

Canonical link: https://commits.webkit.org/259235@main




More information about the webkit-changes mailing list