[webkit-changes] [WebKit/WebKit] 419bb9: [ews-build.webkit.org] Use super for parent class ...
Jonathan Bedard
noreply at github.com
Mon Jan 23 13:07:13 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 419bb9a7d871315e65087dc79d8d0971db5acb82
https://github.com/WebKit/WebKit/commit/419bb9a7d871315e65087dc79d8d0971db5acb82
Author: Jonathan Bedard <jbedard at apple.com>
Date: 2023-01-23 (Mon, 23 Jan 2023)
Changed paths:
M Tools/CISupport/ews-build/steps.py
Log Message:
-----------
[ews-build.webkit.org] Use super for parent class invocations
https://bugs.webkit.org/show_bug.cgi?id=250799
rdar://104400449
Reviewed by Aakash Jain.
As we change classes to new-style for our work migrating to Twisted
defer, we should have classes invoke methods via 'super' so that
code breaks quickly if we change the parent class.
* Tools/CISupport/ews-build/steps.py:
(ShowIdentifier.__init__): Use super instead of directly invoking a class method.
(ShowIdentifier.start): Ditto.
(ShowIdentifier.evaluateCommand): Ditto.
(ShowIdentifier.getResultSummary): Ditto.
(FindModifiedLayoutTests.__init__): Ditto.
(ValidateChange): Ditto.
(RunJavaScriptCoreTests.__init__): Ditto.
(RunJavaScriptCoreTests.start): Ditto.
(RunJavaScriptCoreTests.evaluateCommand): Ditto.
(RunJavaScriptCoreTests.commandComplete): Ditto.
(RunJavaScriptCoreTests.getResultSummary): Ditto.
(RunJSCTestsWithoutChange.evaluateCommand): Ditto.
(RunWebKitTests.__init__): Ditto.
(RunWebKitTests.start): Ditto.
(RunWebKitTests.runCommand): Ditto.
(UploadBuiltProduct.__init__): Ditto.
(TransferToS3.__init__): Ditto.
(DownloadBuiltProductFromMaster.__init__): Ditto.
(UploadTestResults.__init__): Ditto.
(ExtractTestResults.__init__): Ditto.
(ApplyWatchList.__init__): Ditto.
Canonical link: https://commits.webkit.org/259233@main
More information about the webkit-changes
mailing list