[webkit-changes] [WebKit/WebKit] 6ecd79: Remove "copy to secondary path" machinery

[David Quesada]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ecd79a401b2079ed464fe7d3059d7229aa9af7a
      https://github.com/WebKit/WebKit/commit/6ecd79a401b2079ed464fe7d3059d7229aa9af7a
  Author: David Quesada <david_quesada at apple.com>
  Date:   2023-01-23 (Mon, 23 Jan 2023)

  Changed paths:
    M Source/JavaScriptCore/Configurations/Base.xcconfig
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    R Source/JavaScriptCore/Scripts/copy-frameworks-to-secondary-path.sh
    M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
    M Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig
    R Source/ThirdParty/ANGLE/scripts/copy-frameworks-to-secondary-path.sh
    M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
    R Source/ThirdParty/libwebrtc/Scripts/copy-frameworks-to-secondary-path.sh
    M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
    M Source/WebCore/Configurations/WebCore.xcconfig
    R Source/WebCore/Scripts/copy-frameworks-to-secondary-path.sh
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebGPU/Configurations/WebGPU.xcconfig
    R Source/WebGPU/Scripts/copy-frameworks-to-secondary-path.sh
    M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj
    M Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig
    R Source/WebInspectorUI/Scripts/copy-frameworks-to-secondary-path.sh
    M Source/WebInspectorUI/WebInspectorUI.xcodeproj/project.pbxproj
    M Source/WebKit/Configurations/Base.xcconfig
    M Source/WebKit/Configurations/WebKitSwift.xcconfig
    R Source/WebKit/Scripts/copy-frameworks-to-secondary-path.sh
    R Source/WebKit/Scripts/copy-xpc-services-to-secondary-path.sh
    R Source/WebKit/Scripts/update-dyld-environment-load-command
    R Source/WebKit/Scripts/webkitpy/mach_o.py
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj
    M Source/WebKitLegacy/mac/Configurations/Base.xcconfig
    R Source/WebKitLegacy/scripts/copy-frameworks-to-secondary-path.sh

  Log Message:
  -----------
  Remove "copy to secondary path" machinery
https://bugs.webkit.org/show_bug.cgi?id=250905
rdar://93063897

Reviewed by Elliott Williams.

https://bugs.webkit.org/show_bug.cgi?id=237394 introduced mechanisms in the various Xcode
projects to copy products into a second location after they finish building. However, we
never ended up using this behavior, so the associated scripts, build settings, and build
phases are useless cruft now. Clean it all up by removing:

- All "Copy Frameworks to Secondary Path" script phases
- All "Copy XPC Service to Secondary Path" script phases
- All copies of copy-frameworks-to-secondary-path.sh
- WebKit's copy-xpc-services-to-secondary-path.sh
- All definitions of COPY_STAGED_FRAMEWORKS_TO_SECONDARY_PATH, since it was always NO anyway
- All definitions of SECONDARY_STAGED_FRAMEWORK_DIRECTORY and STAGED_DYLIB_FRAMEWORK_PATH,
  since those are only used to build destination paths for copying
- WebKit's update-dyld-environment-load-command, as well as a Mach-O library mach_o.py, which
  is only used by update-dyld-environment-load-command, which itself is only used by the
  product copying machinery to alter the content in secondary path

* Source/JavaScriptCore/Configurations/Base.xcconfig:
* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/Scripts/copy-frameworks-to-secondary-path.sh: Removed.
* Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj:
* Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:
* Source/ThirdParty/ANGLE/scripts/copy-frameworks-to-secondary-path.sh: Removed.
* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:
* Source/ThirdParty/libwebrtc/Scripts/copy-frameworks-to-secondary-path.sh: Removed.
* Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:
* Source/WebCore/Configurations/WebCore.xcconfig:
* Source/WebCore/Scripts/copy-frameworks-to-secondary-path.sh: Removed.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebGPU/Configurations/WebGPU.xcconfig:
* Source/WebGPU/Scripts/copy-frameworks-to-secondary-path.sh: Removed.
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:
* Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig:
* Source/WebInspectorUI/Scripts/copy-frameworks-to-secondary-path.sh: Removed.
* Source/WebInspectorUI/WebInspectorUI.xcodeproj/project.pbxproj:
* Source/WebKit/Configurations/Base.xcconfig:
* Source/WebKit/Configurations/WebKitSwift.xcconfig:
* Source/WebKit/Scripts/copy-frameworks-to-secondary-path.sh: Removed.
* Source/WebKit/Scripts/copy-xpc-services-to-secondary-path.sh: Removed.
* Source/WebKit/Scripts/update-dyld-environment-load-command: Removed.
* Source/WebKit/Scripts/webkitpy/mach_o.py: Removed.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/mac/Configurations/Base.xcconfig:
* Source/WebKitLegacy/scripts/copy-frameworks-to-secondary-path.sh: Removed.

Canonical link: https://commits.webkit.org/259214@main