[webkit-changes] [WebKit/WebKit] 2cdbf5: Remove the `HAVE(LARGE_CONTROL_SIZE)` compile-time...

Aditya Keerthi noreply at github.com
Sun Jan 22 20:06:12 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2cdbf509a7e7e66744cb8ecc75267b1f5b29d477
      https://github.com/WebKit/WebKit/commit/2cdbf509a7e7e66744cb8ecc75267b1f5b29d477
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-01-22 (Sun, 22 Jan 2023)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/PAL/pal/spi/mac/CoreUISPI.h
    M Source/WebCore/platform/PopupMenuStyle.h
    M Source/WebCore/platform/mac/ThemeMac.h
    M Source/WebCore/platform/mac/ThemeMac.mm
    M Source/WebCore/rendering/RenderThemeMac.mm
    M Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm

  Log Message:
  -----------
  Remove the `HAVE(LARGE_CONTROL_SIZE)` compile-time flag
https://bugs.webkit.org/show_bug.cgi?id=250959
rdar://104519306

Reviewed by Wenson Hsieh.

`HAVE(LARGE_CONTROL_SIZE)` is only consulted on macOS, and is always true as of
macOS 11.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/PAL/pal/spi/mac/CoreUISPI.h:
* Source/WebCore/platform/PopupMenuStyle.h:
* Source/WebCore/platform/mac/ThemeMac.h:
* Source/WebCore/platform/mac/ThemeMac.mm:
(WebCore::controlSizeForFont):
(WebCore::controlSizeFromPixelSize):
(WebCore::radioSizes):
(WebCore::setUpButtonCell):
(WebCore::stepperControlSizeForFont):
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::supportsLargeFormControls const):
(WebCore::RenderThemeMac::controlSizeForFont const):
(WebCore::RenderThemeMac::controlSizeForCell const):
(WebCore::RenderThemeMac::controlSizeForSystemFont const):
(WebCore::RenderThemeMac::popupMenuSize const):
* Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
* Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::show):

Canonical link: https://commits.webkit.org/259201@main




More information about the webkit-changes mailing list