[webkit-changes] [WebKit/WebKit] fe6107: Move style build time functions from CSSParser to ...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe6107c38245cb617a14c3d96783dcc96b6702ab
      https://github.com/WebKit/WebKit/commit/fe6107c38245cb617a14c3d96783dcc96b6702ab
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-01-22 (Sun, 22 Jan 2023)

  Changed paths:
    M Source/WebCore/css/parser/CSSParser.cpp
    M Source/WebCore/css/parser/CSSParser.h
    M Source/WebCore/style/StyleBuilder.cpp
    M Source/WebCore/style/StyleBuilderState.h

  Log Message:
  -----------
  Move style build time functions from CSSParser to Style::Builder
https://bugs.webkit.org/show_bug.cgi?id=250980

Reviewed by Alan Baradlay.

They don't really belong to the CSS parser.

* Source/WebCore/css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseValueWithVariableReferences): Deleted.
(WebCore::CSSParser::parseCustomPropertyValueWithVariableReferences): Deleted.

The code in these functions moves to their only callers.
CSSParser does not depend on the style builder state anymore.

* Source/WebCore/css/parser/CSSParser.h:
* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::resolveVariableReferences):
(WebCore::Style::Builder::resolveCustomPropertyValueWithVariableReferences):
* Source/WebCore/style/StyleBuilderState.h:
(WebCore::Style::BuilderState::inProgressProperties const): Deleted.
(WebCore::Style::BuilderState::inUnitCycleProperties): Deleted.

These can be private to the style builder.

Canonical link: https://commits.webkit.org/259191@main