[webkit-changes] [WebKit/WebKit] 9aee9b: [IFC] Merge text-edge logic for inline box ascent/...

Alan Baradlay noreply at github.com
Sun Jan 22 08:07:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9aee9b7e0031bdca0cbdafad852c7e12555ec8b3
      https://github.com/WebKit/WebKit/commit/9aee9b7e0031bdca0cbdafad852c7e12555ec8b3
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-01-22 (Sun, 22 Jan 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h

  Log Message:
  -----------
  [IFC] Merge text-edge logic for inline box ascent/descent and layout bounds
https://bugs.webkit.org/show_bug.cgi?id=250960

Reviewed by Antti Koivisto.

Text-edge drives inline boxes' layout bounds values, but it also affects the computed
ascent/descent when leading-trim is set (start/end).

* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::ascentAndDescentWithTextEdgeForInlineBox):
(WebCore::Layout::LineBoxBuilder::setLayoutBoundsForInlineBox const):
(WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox const):
(WebCore::Layout::LineBoxBuilder::computedAsentAndDescentForInlineBox const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h:

Canonical link: https://commits.webkit.org/259184@main




More information about the webkit-changes mailing list