[webkit-changes] [WebKit/WebKit] 455b1b: RemoteAudioDestinationManager CreateAudioDestinati...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 455b1bcd78ac0727d594031726392b23e0b76e1c
      https://github.com/WebKit/WebKit/commit/455b1bcd78ac0727d594031726392b23e0b76e1c
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-01-21 (Sat, 21 Jan 2023)

  Changed paths:
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
    M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp
    M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.h
    M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.messages.in
    M Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp

  Log Message:
  -----------
  RemoteAudioDestinationManager CreateAudioDestination is synchronous message
https://bugs.webkit.org/show_bug.cgi?id=250895
rdar://104473100

Reviewed by Eric Carlson.

Audio destination creation is sometimes on critical path in loading.
The message does not need to be synchronous, as the identifier can
be as well selected by the WebProcess during creation.

Select the identifier in WP, make the message asynchronous, delete the
identifier member variable from the GPUP object.

* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::dispatchSyncMessage):
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:
(WebKit::RemoteAudioDestinationManager::createAudioDestination):
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.h:
(WebKit::RemoteAudioDestinationManager::didReceiveSyncMessageFromWebProcess): Deleted.
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.messages.in:
* Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::connection):

Canonical link: https://commits.webkit.org/259167@main