[webkit-changes] [WebKit/WebKit] 83a1bc: [JSC][armv7] Use the correct calling convention fo...
jjgriego
noreply at github.com
Fri Jan 20 12:10:01 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 83a1bc69e51b312580fb05cb9fb683cc801ae47e
https://github.com/WebKit/WebKit/commit/83a1bc69e51b312580fb05cb9fb683cc801ae47e
Author: Joseph Griego <jgriego at igalia.com>
Date: 2023-01-20 (Fri, 20 Jan 2023)
Changed paths:
M Source/JavaScriptCore/wasm/WasmAirIRGenerator32_64.cpp
Log Message:
-----------
[JSC][armv7] Use the correct calling convention for `operationWasmRethrow`
https://bugs.webkit.org/show_bug.cgi?id=250588
Reviewed by Mark Lam.
https://github.com/WebKit/WebKit/pull/8523 changed the signature of some runtime
wasm operations, but incorrectly translated these changes for the arm32 calling
convention, breaking some tests.
Changes to other wasm operations were covered by the platform-specific
`emitCCall`, but calls to `operationWasmRethrow` are not emitted this way.
(The arm32 calling convention requires that 64-bit arguments get passed starting
in an even-numbered registers, potentially causing an odd-numbered register to
be unused in the call, in this case, `r1/argumentGPR1`)
* Source/JavaScriptCore/wasm/WasmAirIRGenerator32_64.cpp:
(JSC::Wasm::AirIRGenerator32::addRethrow):
Canonical link: https://commits.webkit.org/259152@main
More information about the webkit-changes
mailing list