[webkit-changes] [WebKit/WebKit] 3c729e: AudioContext::suspend creates a remote audio desti...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3c729e10ad7a04cb531fbce23850242271c48222
      https://github.com/WebKit/WebKit/commit/3c729e10ad7a04cb531fbce23850242271c48222
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
    M Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp

  Log Message:
  -----------
  AudioContext::suspend creates a remote audio destination
https://bugs.webkit.org/show_bug.cgi?id=250890
rdar://problem/104470320

Reviewed by Youenn Fablet.

Stopping RemoteAudioDestinationProxy that was not started would
establish a connection to GPUP RemoteAudioDestination. This is a slow
operation.

This would happen sometimes during load, where load commit would suspend
the AudioContext that the page created but did not start. AudioContext
starts in Suspended state, but suspending it would cause stop call
to the underlying destination.

To minimize the change at this time, fix the problem at
RemoteAudioDestinationProxy level. Later on, AudioContext can be
improved further.

* Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::startRendering):
(WebKit::RemoteAudioDestinationProxy::stopRendering):

Canonical link: https://commits.webkit.org/259134@main