[webkit-changes] [WebKit/WebKit] 9c6dfd: No gap between the hero image and text on amazon p...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c6dfde26b8a04fbdcbb0de44efb6a56a71178ed
      https://github.com/WebKit/WebKit/commit/9c6dfde26b8a04fbdcbb0de44efb6a56a71178ed
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-01-19 (Thu, 19 Jan 2023)

  Changed paths:
    A LayoutTests/fast/block/percent-margin-start-end-with-floats-expected.html
    A LayoutTests/fast/block/percent-margin-start-end-with-floats.html
    M Source/WebCore/rendering/GridLayoutFunctions.cpp
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderBox.h
    M Source/WebCore/rendering/RenderFlexibleBox.cpp
    M Source/WebCore/rendering/RenderTable.cpp

  Log Message:
  -----------
  No gap between the hero image and text on amazon product page
https://bugs.webkit.org/show_bug.cgi?id=249871
<rdar://problem/103685984>

Reviewed by Antti Koivisto.

Only "margin: auto" is supposed to be resolved against the "available width adjusted with intrusive floats" (e.g. percent values are based on container width).
(see webkit.org/b/83614)

* LayoutTests/fast/block/percent-margin-start-end-with-floats-expected.html: Added.
* LayoutTests/fast/block/percent-margin-start-end-with-floats.html: Added.
* Source/WebCore/rendering/GridLayoutFunctions.cpp:
(WebCore::GridLayoutFunctions::computeMarginLogicalSizeForChild):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInFragment const):
(WebCore::RenderBox::computeInlineDirectionMargins const):
(WebCore::RenderBox::computeLogicalHeight const):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisMarginExtentForChild const):
(WebCore::RenderFlexibleBox::crossAxisMarginExtentForChild const):
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::updateLogicalWidth):

Canonical link: https://commits.webkit.org/259125@main