[webkit-changes] [WebKit/WebKit] 8ad055: Small improvement to VMInspector::dumpRegisters().
EWS
noreply at github.com
Thu Jan 19 13:21:24 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8ad0557c285f30037acb8bd45cd7397ccd10988e
https://github.com/WebKit/WebKit/commit/8ad0557c285f30037acb8bd45cd7397ccd10988e
Author: Mark Lam <mark.lam at apple.com>
Date: 2023-01-19 (Thu, 19 Jan 2023)
Changed paths:
M Source/JavaScriptCore/bytecode/CodeBlock.cpp
M Source/JavaScriptCore/tools/VMInspector.cpp
Log Message:
-----------
Small improvement to VMInspector::dumpRegisters().
https://bugs.webkit.org/show_bug.cgi?id=250857
<rdar://problem/104439794>
Reviewed by Yusuke Suzuki.
When dumping the topCallFrame, we should use numCalleeLocals instead of numVars when we don't
know where the next frame is. Using numVars does not give us visibility into all locals that
may be in use.
Also fix CodeBlock::nameForRegister() to just use VirtualRegister's dumper instead of doing
custom and duplicate work.
* Source/JavaScriptCore/bytecode/CodeBlock.cpp:
(JSC::CodeBlock::nameForRegister):
* Source/JavaScriptCore/tools/VMInspector.cpp:
(JSC::VMInspector::dumpRegisters):
Canonical link: https://commits.webkit.org/259109@main
More information about the webkit-changes
mailing list