[webkit-changes] [WebKit/WebKit] 6eb6b7: De-duplicate feature flags from Settings.yaml that...

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6eb6b7e29314edc08edee2733bb39e89b27d31c4
      https://github.com/WebKit/WebKit/commit/6eb6b7e29314edc08edee2733bb39e89b27d31c4
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2023-01-19 (Thu, 19 Jan 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/editing/cocoa/DataDetectorType.h
    M Source/WebCore/page/Settings.yaml
    M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb

  Log Message:
  -----------
  De-duplicate feature flags from Settings.yaml that are provided by UnifiedWebPreferences.yaml
https://bugs.webkit.org/show_bug.cgi?id=250778
<rdar://problem/104389479>

Reviewed by Elliott Williams.

A number of preferences defined in UnifiedWebPreferences.yaml are duplicated in Settings.yaml.
The generator handles this case properly, but it's confusing to developers.

This patch also removed the unused MediaDeviceIdentifierStorageDirectory item.

It also restores the 'Settings.yaml' file to the Xcode project so that search will
locate items within it.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Clean up duplicates.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj: Add missing Settings.yaml file.
* Source/WebCore/editing/cocoa/DataDetectorType.h: Add a 'None' case.
* Source/WebCore/page/Settings.yaml: Remove duplicates.
* Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb: Downcast enums to integral types.

Canonical link: https://commits.webkit.org/259101@main