[webkit-changes] [WebKit/WebKit] 56a5e5: Fix crash when a video without source is played wi...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 56a5e513db94308a4aeea8b6a4c63335196821ee
      https://github.com/WebKit/WebKit/commit/56a5e513db94308a4aeea8b6a4c63335196821ee
  Author: Chirag M Shah <chirags2793 at gmail.com>
  Date:   2023-01-19 (Thu, 19 Jan 2023)

  Changed paths:
    A LayoutTests/http/tests/media/video-play-without-load-expected.txt
    A LayoutTests/http/tests/media/video-play-without-load.html
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  Fix crash when a video without source is played without loading
https://bugs.webkit.org/show_bug.cgi?id=250810
rdar://104278707

Reviewed by Jer Noble.

Before this change, we used to initialize m_currentIdentifier only when
source was set on a HTMLElement, or when we are preloading content,
which resulted in a crash when none of those happened because we would
send an empty object identifier across IPC. This change fixes that.

* LayoutTests/http/tests/media/video-play-without-load-expected.txt: Added.
* LayoutTests/http/tests/media/video-play-without-load.html: Added.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):

Canonical link: https://commits.webkit.org/259097@main