[webkit-changes] [WebKit/WebKit] c2ae62: REGRESSION (STP 161): html/browsers/the-window-obj...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2ae62c47dc21cf6cc77bd1f208a45a4f4e1cb9b
      https://github.com/WebKit/WebKit/commit/c2ae62c47dc21cf6cc77bd1f208a45a4f4e1cb9b
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-01-19 (Thu, 19 Jan 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-height.html
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-innerheight.html
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-innerwidth.html
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-left.html
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screenx-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screenx.html
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screeny-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screeny.html
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-top.html
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-width.html
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/resources/message-opener.html
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screenx-expected.txt
    M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screenx-expected.txt

  Log Message:
  -----------
  REGRESSION (STP 161): html/browsers/the-window-object/open-close 14 test failures on WPT
https://bugs.webkit.org/show_bug.cgi?id=250591
rdar://104237236

Reviewed by Geoffrey Garen.

The tests open popups with various dimension/position parameters. Upon opening, the popup messages
back its dimension/position to the opener to validate that the parameters worked as intended.
However, the popup dimension/position may get updated asynchronously and may be subject to
animations. This was resulting in the tests being flaky.

To address the issue, we now pass an extra query parameter to the popup to indicate the expected
dimension/position. This allows the popup code to wait a bit to see if the dimension/position
eventually becomes the expected one or not.

* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-height.html:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-innerheight.html:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-innerwidth.html:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-left.html:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screenx-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screenx.html:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screeny-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screeny.html:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-top.html:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-width.html:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/resources/message-opener.html:

Canonical link: https://commits.webkit.org/259084@main