[webkit-changes] [WebKit/WebKit] f5b520: SVGRenderStyle should repaint on resolved color ch...

[Matthieu Dubet]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5b520fdec0edc2996ac754c2fa8f13fd2a7fb05
      https://github.com/WebKit/WebKit/commit/f5b520fdec0edc2996ac754c2fa8f13fd2a7fb05
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2023-01-19 (Thu, 19 Jan 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/svg/painting/svg-currentcolor-dynamic-inherit-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/svg/painting/svg-currentcolor-dynamic-inherit.html
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/SVGRenderStyle.cpp
    M Source/WebCore/rendering/style/SVGRenderStyle.h

  Log Message:
  -----------
  SVGRenderStyle should repaint on resolved color change
https://bugs.webkit.org/show_bug.cgi?id=250718
rdar://102904403

Reviewed by Antti Koivisto.

Before this patch, the diff algorithm would naively
compare the color properties value without taking into
account the dynamic nature of "currentcolor".

* LayoutTests/imported/w3c/web-platform-tests/svg/painting/svg-currentcolor-dynamic-inherit-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/svg/painting/svg-currentcolor-dynamic-inherit.html: Added.
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout const):
(WebCore::RenderStyle::changeRequiresRepaint const):
(WebCore::RenderStyle::diff const):
* Source/WebCore/rendering/style/SVGRenderStyle.cpp:
(WebCore::colorChangeRequiresRepaint):
(WebCore::SVGRenderStyle::changeRequiresLayout const):
(WebCore::SVGRenderStyle::changeRequiresRepaint const):
(WebCore::SVGRenderStyle::diff const): Deleted.
* Source/WebCore/rendering/style/SVGRenderStyle.h:

Canonical link: https://commits.webkit.org/259082@main