[webkit-changes] [WebKit/WebKit] 972107: Remove HTMLFrameElement.location

Ahmad Saleem noreply at github.com
Wed Jan 18 23:16:08 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9721073a6b93730a55d35861ecab3fac47313131
      https://github.com/WebKit/WebKit/commit/9721073a6b93730a55d35861ecab3fac47313131
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-01-18 (Wed, 18 Jan 2023)

  Changed paths:
    R LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt
    R LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html
    M LayoutTests/platform/win/TestExpectations
    M Source/WebCore/html/HTMLFrameElement.idl
    M Source/WebCore/html/HTMLFrameElementBase.cpp
    M Source/WebCore/html/HTMLFrameElementBase.h
    M Source/WebCore/page/PageColorSampler.cpp
    M Source/WebKitLegacy/mac/DOM/DOMHTMLFrameElement.mm

  Log Message:
  -----------
  Remove HTMLFrameElement.location

Remove HTMLFrameElement.location
https://bugs.webkit.org/show_bug.cgi?id=250592

Reviewed by Ryosuke Niwa.

This patch is to align WebKit with Gecko / Firefox and Blink / Chrome by
removing non-standard attribute.

This patch removes 'location' attribute from HTMLFrameElement, which
was non-standard and WebKit only. This was never supported by Gecko
and Internet Explorer. It was removed by Blink in 2014 as well.

* Source/WebCore/html/HTMLFrameElementBase.cpp:
(HTMLFrameElementBase::location): Removed
* Source/WebCore/html/HTMLFrameElementBase.h: Remove 'location' and move 'setLocation' to 'protected'
* Sourfce/WebCore/html/HTMLFrameElement.idl: Remove 'location'
* Source/WebCore/page/PageColorSampler.cpp:
(isValidSampleLocation): Remove "location" reference
* Source/WebKitLegacy/mac/DOM/DOMHTMLFrameElement.mm: Return nullptr for 'location' and early return for "setLocation"
* LayoutTests/http/tests/secur…/javascriptURL-execution-context-frame-location-htmldom.html: Removed
* LayoutTests/http/tests/secur…/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Removed
* LayoutTests/platform/win/TestExpectations: Remove expectation of removed test case

Canonical link: https://commits.webkit.org/259067@main




More information about the webkit-changes mailing list