[webkit-changes] [WebKit/WebKit] 53cde7: [GPU Process] [FormControls] Add ControlPart for I...

Said Abou-Hallawa noreply at github.com
Wed Jan 18 16:27:56 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53cde7bfd6be60b50e8031edf9a150dbe74e30a3
      https://github.com/WebKit/WebKit/commit/53cde7bfd6be60b50e8031edf9a150dbe74e30a3
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-01-18 (Wed, 18 Jan 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/platform/graphics/controls/ControlFactory.h
    A Source/WebCore/platform/graphics/controls/ImageControlsButtonPart.h
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm
    A Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.h
    A Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.mm
    M Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.h
    M Source/WebCore/platform/graphics/mac/controls/SliderThumbMac.h
    M Source/WebCore/platform/graphics/mac/controls/SliderThumbMac.mm
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderThemeMac.h
    M Source/WebCore/rendering/RenderThemeMac.mm
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp

  Log Message:
  -----------
  [GPU Process] [FormControls] Add ControlPart for ImageControlsButton
https://bugs.webkit.org/show_bug.cgi?id=250664
rdar://104288189

Reviewed by Aditya Keerthi.

Drawing this control part will be moved to GraphicsContext so it can be recorded
in WebProcess and drawn in GPUProcess if DOM rendering is enabled for GPUProcess.

* Source/WebCore/Headers.cmake:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/controls/ControlFactory.h:
* Source/WebCore/platform/graphics/controls/ImageControlsButtonPart.h: Copied from Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.h.
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm:
(WebCore::ControlFactoryMac::sharedControlFactory):
(WebCore::ControlFactoryMac::servicesRolloverButtonCell const):
(WebCore::ControlFactoryMac::createPlatformImageControlsButton):
* Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.h: Copied from Source/WebCore/platform/graphics/mac/controls/SliderThumbMac.h.
* Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.mm: Copied from Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.h.
(WebCore::ImageControlsButtonMac::ImageControlsButtonMac):
(WebCore::ImageControlsButtonMac::servicesRolloverButtonCellSize):
(WebCore::ImageControlsButtonMac::draw):
* Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.h:
* Source/WebCore/platform/graphics/mac/controls/SliderThumbMac.h:
* Source/WebCore/platform/graphics/mac/controls/SliderThumbMac.mm:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::createControlPart const):
* Source/WebCore/rendering/RenderThemeMac.h:
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::canPaint const):
(WebCore::RenderThemeMac::canCreateControlPartForRenderer const):
(WebCore::RenderThemeMac::imageControlsButtonSize const):
(WebCore::RenderThemeMac::servicesRolloverButtonCell const): Deleted.
(WebCore::RenderThemeMac::paintImageControlsButton): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ControlPart>::decode):

Canonical link: https://commits.webkit.org/259061@main




More information about the webkit-changes mailing list