[webkit-changes] [WebKit/WebKit] 70f33f: Assertion failure in ContainerNode::removeNodeWith...
Ryosuke Niwa
noreply at github.com
Wed Jan 18 09:42:03 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 70f33f17ad48a4dd5defd7a6f7dc72b6764bf8bb
https://github.com/WebKit/WebKit/commit/70f33f17ad48a4dd5defd7a6f7dc72b6764bf8bb
Author: Ryosuke Niwa <rniwa at webkit.org>
Date: 2023-01-18 (Wed, 18 Jan 2023)
Changed paths:
A LayoutTests/fast/replaced/pdf-iframe-load-crash-expected.txt
A LayoutTests/fast/replaced/pdf-iframe-load-crash.html
A LayoutTests/fast/replaced/resources/pdf-iframe-load-crash.pdf
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/win/TestExpectations
M Source/WebCore/dom/Document.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm
Log Message:
-----------
Assertion failure in ContainerNode::removeNodeWithScriptAssertion via ~PDFPluginTextAnnotation
https://bugs.webkit.org/show_bug.cgi?id=250726
Reviewed by Chris Dumez.
The debug assertion failure was caused by PDFPluginAnnotation trying to synchronously remove
the annotations. While this is safe since it happens inside a PDF document, delay the work using
the event loop anyway to avoid hitting this assertion.
* LayoutTests/fast/replaced/pdf-iframe-load-crash-expected.txt: Added.
* LayoutTests/fast/replaced/pdf-iframe-load-crash.html: Added.
* LayoutTests/fast/replaced/resources/pdf-iframe-load-crash.pdf: Added.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/win/TestExpectations:
* Source/WebCore/dom/Document.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::~PDFPluginAnnotation):
Canonical link: https://commits.webkit.org/259033@main
More information about the webkit-changes
mailing list