[webkit-changes] [WebKit/WebKit] 0e9c19: [@property] Initial value cleanups

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0e9c19d6b9a6b5d1604dbe2f531b147eb0a5c9f9
      https://github.com/WebKit/WebKit/commit/0e9c19d6b9a6b5d1604dbe2f531b147eb0a5c9f9
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-01-17 (Tue, 17 Jan 2023)

  Changed paths:
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/css/CSSRegisteredCustomProperty.cpp
    M Source/WebCore/css/CSSRegisteredCustomProperty.h
    M Source/WebCore/css/CSSVariableReferenceValue.cpp
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/style/CustomPropertyRegistry.cpp
    M Source/WebCore/style/CustomPropertyRegistry.h
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  [@property] Initial value cleanups
https://bugs.webkit.org/show_bug.cgi?id=250707
rdar://104330630

Reviewed by Antoine Quint.

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::blendCustomProperty):
(WebCore::CSSPropertyAnimation::propertyRequiresBlendingForAccumulativeIteration):
(WebCore::CSSPropertyAnimation::propertiesEqual):
(WebCore::CSSPropertyAnimation::canPropertyBeInterpolated):
* Source/WebCore/css/CSSRegisteredCustomProperty.cpp:
(WebCore::CSSRegisteredCustomProperty::CSSRegisteredCustomProperty): Deleted.
(WebCore::CSSRegisteredCustomProperty::initialValueCopy const): Deleted.
* Source/WebCore/css/CSSRegisteredCustomProperty.h:
(WebCore::CSSRegisteredCustomProperty::initialValue const): Deleted.

Just make the field public.

* Source/WebCore/css/CSSVariableReferenceValue.cpp:
(WebCore::CSSVariableReferenceValue::resolveVariableReference const):
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::customPropertyValue):

Remove the dead leftover code for resolving Length values.

* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::changedCustomPaintWatchedProperty):
(WebCore::RenderStyle::customPropertyValue const):

Handle resolving the initial value for a registered property here. Clients have to provide the registry.

(WebCore::RenderStyle::customPropertyValueWithoutResolvingInitial const):
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::getCustomProperty const): Deleted.
* Source/WebCore/style/CustomPropertyRegistry.cpp:
(WebCore::Style::CustomPropertyRegistry::get const):
(WebCore::Style::CustomPropertyRegistry::isInherited const):
* Source/WebCore/style/CustomPropertyRegistry.h:
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInitialCustomProperty):

Canonical link: https://commits.webkit.org/258991@main