[webkit-changes] [WebKit/WebKit] 645b90: [WPE][GTK] Remove most property nicks/blurbs

Michael Catanzaro noreply at github.com
Tue Jan 17 00:47:44 PST 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 645b9044d2369e3b083b171da517a2440bb4fa18
      https://github.com/WebKit/WebKit/commit/645b9044d2369e3b083b171da517a2440bb4fa18
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2023-01-17 (Tue, 17 Jan 2023)

  Changed paths:
    M Source/JavaScriptCore/API/glib/JSCClass.cpp
    M Source/JavaScriptCore/API/glib/JSCContext.cpp
    M Source/JavaScriptCore/API/glib/JSCValue.cpp
    M Source/JavaScriptCore/API/glib/JSCWeakValue.cpp
    M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/TextCombinerPadGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/WebKitAudioSinkGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp
    M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp
    M Source/WebCore/platform/gtk/po/POTFILES.in
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
    M Source/WebKit/Shared/API/glib/WebKitHitTestResult.cpp
    M Source/WebKit/Shared/API/glib/WebKitURIRequest.cpp
    M Source/WebKit/Shared/API/glib/WebKitURIResponse.cpp
    M Source/WebKit/Shared/API/glib/WebKitUserMessage.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitAutomationSession.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitEditorState.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitFileChooserRequest.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitFindController.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitInputMethodContext.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitNavigationPolicyDecision.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitNotification.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitResponsePolicyDecision.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitURISchemeResponse.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitUserContentFilterStore.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitUserMediaPermissionRequest.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebResource.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebsitePolicies.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWindowProperties.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitColorChooserRequest.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitPrintCustomWidget.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitWebInspector.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/DOM/WebKitDOMObject.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebHitTestResult.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp
    M Tools/MiniBrowser/gtk/BrowserCellRendererVariant.c
    M Tools/MiniBrowser/gtk/BrowserSettingsDialog.c
    M Tools/MiniBrowser/gtk/BrowserTab.c

  Log Message:
  -----------
  [WPE][GTK] Remove most property nicks/blurbs
https://bugs.webkit.org/show_bug.cgi?id=250688

Reviewed by Carlos Garcia Campos.

GObject property nicks and blurbs are mostly useless and require
thinking to write, so we should get rid of almost all of them. This is
especially beneficial for translators: most (but not all) of our nicks
and blurbs are translated, and it's wasted effort to translate something
that is never used. GTK has already removed its nicks and blurbs in
https://gitlab.gnome.org/GNOME/gtk/-/issues/4904, and we should follow.

Well, mostly. An exception is WebKitSettings. MiniBrowser is using the
nicks and blurbs to programatically create its settings dialog. This is
probably the best use of nicks and blurbs that I've ever seen. Keep the
nicks and blurbs here to not break this. I've also not touched the
deprecated GTK DOM API, since all of these files will be deleted in the
distant future, and none of them are marked for translation, so they're
not actively hurting anything.

* Source/JavaScriptCore/API/glib/JSCClass.cpp:
(jsc_class_class_init):
* Source/JavaScriptCore/API/glib/JSCContext.cpp:
(jsc_context_class_init):
* Source/JavaScriptCore/API/glib/JSCValue.cpp:
(jsc_value_class_init):
* Source/JavaScriptCore/API/glib/JSCWeakValue.cpp:
(jsc_weak_value_class_init):
* Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_class_init):
* Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp:
(webkit_dmabuf_video_sink_class_init):
* Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:
(webkit_gl_video_sink_class_init):
* Source/WebCore/platform/graphics/gstreamer/TextCombinerPadGStreamer.cpp:
(webkit_text_combiner_pad_class_init):
* Source/WebCore/platform/graphics/gstreamer/WebKitAudioSinkGStreamer.cpp:
(webkit_audio_sink_class_init):
* Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_class_init):
* Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webkit_media_src_class_init):
* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(webkit_video_encoder_class_init):
* Source/WebCore/platform/gtk/po/POTFILES.in:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkit_media_stream_src_class_init):
* Source/WebKit/Shared/API/glib/WebKitHitTestResult.cpp:
(webkit_hit_test_result_class_init):
* Source/WebKit/Shared/API/glib/WebKitURIRequest.cpp:
(webkit_uri_request_class_init):
* Source/WebKit/Shared/API/glib/WebKitURIResponse.cpp:
(webkit_uri_response_class_init):
* Source/WebKit/Shared/API/glib/WebKitUserMessage.cpp:
(webkit_user_message_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitAutomationSession.cpp:
(webkit_automation_session_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp:
(webkit_download_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitEditorState.cpp:
(webkit_editor_state_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitFindController.cpp:
(webkit_find_controller_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:
(webkit_geolocation_manager_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitInputMethodContext.cpp:
(webkit_input_method_context_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitNavigationPolicyDecision.cpp:
(webkit_navigation_policy_decision_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitNotification.cpp:
(webkit_notification_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitResponsePolicyDecision.cpp:
(webkit_response_policy_decision_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitURISchemeResponse.cpp:
(webkit_uri_scheme_response_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitUserContentFilterStore.cpp:
(webkit_user_content_filter_store_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitUserMediaPermissionRequest.cpp:
(webkit_user_media_permission_request_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:
(webkit_web_context_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitWebResource.cpp:
(webkit_web_resource_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(webkit_web_view_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
(webkit_website_data_manager_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitWebsitePolicies.cpp:
(webkit_website_policies_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitWindowProperties.cpp:
(webkit_window_properties_class_init):
* Source/WebKit/UIProcess/API/gtk/WebKitColorChooserRequest.cpp:
(webkit_color_chooser_request_class_init):
* Source/WebKit/UIProcess/API/gtk/WebKitPrintCustomWidget.cpp:
(webkit_print_custom_widget_class_init):
* Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkit_print_operation_class_init):
* Source/WebKit/UIProcess/API/gtk/WebKitWebInspector.cpp:
(webkit_web_inspector_class_init):
* Source/WebKit/WebProcess/InjectedBundle/API/glib/DOM/WebKitDOMObject.cpp:
(webkit_dom_object_class_init):
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebHitTestResult.cpp:
(webkit_web_hit_test_result_class_init):
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
(webkit_web_page_class_init):
* Tools/MiniBrowser/gtk/BrowserCellRendererVariant.c:
(browser_cell_renderer_variant_class_init):
* Tools/MiniBrowser/gtk/BrowserSettingsDialog.c:
(browser_settings_dialog_class_init):
* Tools/MiniBrowser/gtk/BrowserTab.c:
(browser_tab_class_init):

Canonical link: https://commits.webkit.org/258973@main

More information about the webkit-changes mailing list