[webkit-changes] [WebKit/WebKit] 4d09ec: [MQ4] Fix css/mediaqueries/negation-001.html and a...

Antti Koivisto noreply at github.com
Mon Jan 16 06:35:15 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d09ec91ef71a968c3f8a23682d56dac25d60e24
      https://github.com/WebKit/WebKit/commit/4d09ec91ef71a968c3f8a23682d56dac25d60e24
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-01-16 (Mon, 16 Jan 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/negation-001.html
    M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html

  Log Message:
  -----------
  [MQ4] Fix css/mediaqueries/negation-001.html and add more 3-valued logic tests
https://bugs.webkit.org/show_bug.cgi?id=250674
rdar://104296041

Reviewed by Kimmo Kinnunen.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/negation-001.html:

Fix the test. The query

not ((unknown) or (monochrome))

evaluates using 3-valued Kleene logic to

-> not (unknown or false)
-> not unknown
-> unknown

which in media query context doesn't match. Firefox agrees.

* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html:

Add more tests for 3-valued logic. Firefox passes all these too.

Also add a parsing test for an unknown function with extra whitespace.

Canonical link: https://commits.webkit.org/258952@main




More information about the webkit-changes mailing list