[webkit-changes] [WebKit/WebKit] a107c4: A no-store request should have its cache policy se...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a107c4cce18136b2e307b91d2bdb9b20f651f0b5
      https://github.com/WebKit/WebKit/commit/a107c4cce18136b2e307b91d2bdb9b20f651f0b5
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-01-16 (Mon, 16 Jan 2023)

  Changed paths:
    A LayoutTests/fast/constructors/event-source-caching-expected.txt
    A LayoutTests/fast/constructors/event-source-caching.html
    M Source/WebCore/loader/cache/CachedResourceLoader.cpp
    M Source/WebCore/loader/cache/CachedResourceRequest.cpp
    M Source/WebCore/loader/cache/CachedResourceRequest.h

  Log Message:
  -----------
  A no-store request should have its cache policy set to disallow even if its URL is not HTTP
https://bugs.webkit.org/show_bug.cgi?id=250451
rdar://102888724

Reviewed by Chris Dumez.

There is a debug assert checking fetch options cache mode when checking whether to reuse a MemoryCache cache entry.
EventSource should never reuse the memory cache and set fetch options cache mode to no-store.
Previously, we were only setting the cache option to disallow for HTTP URLs.
We are now doing it for all URLs.

* LayoutTests/fast/constructors/event-source-caching-expected.txt: Added.
* LayoutTests/fast/constructors/event-source-caching.html: Added.
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):

Canonical link: https://commits.webkit.org/258942@main