[webkit-changes] [WebKit/WebKit] 580e96: Compute the keyTimes index correctly for discrete ...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 580e9612e2c69282a564a14213dff82250b4bda8
      https://github.com/WebKit/WebKit/commit/580e9612e2c69282a564a14213dff82250b4bda8
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-01-15 (Sun, 15 Jan 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-elem-14-t-drt-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-elem-18-t-drt-expected.txt
    M LayoutTests/svg/animations/animate-elem-14-t-drt-expected.txt
    M LayoutTests/svg/animations/animate-elem-18-t-drt-expected.txt
    M Source/WebCore/svg/SVGAnimationElement.cpp

  Log Message:
  -----------
  Compute the keyTimes index correctly for discrete (values) animations

Compute the keyTimes index correctly for discrete (values) animations
https://bugs.webkit.org/show_bug.cgi?id=250643

Reviewed by Simon Fraser.

This patch is to align WebKit with Blink / Chromium and Gecko / Firefox.

Merge - https://chromium.googlesource.com/chromium/blink/+/be50d8baacafe25f3a96d22be3e9a96ab882df4a

This patch is to modify to ensure that the last value is allowed to be non-one
for discrete mode animations (but not for linear and spline mode animations).

* Source/WebCore/svg/SVGAnimationElement.cpp:
(SVGAnimationElement::calaculateKeyTimesIndex): Update function to exclude 'discrete' mode
(SVGAnimationElement::calculatePercentFromKeyPoints): Add ASSERT and move functions after Disrete mode
* LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-elem-18-t-drt-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-elem-14-t-drt-expected.txt: Ditto
* LayoutTests/svg/animations/animate-elem-14-t-drt-expected.txt: Ditto
* LayoutTests/svg/animations/animate-elem-18-t-drt-expected.txt: Ditto

Canonical link: https://commits.webkit.org/258939@main