[webkit-changes] [WebKit/WebKit] 0b04b9: [WPE][GTK] Rename environment variable for turning...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b04b92cda5a40db22a88fd41baed130945ae07d
      https://github.com/WebKit/WebKit/commit/0b04b92cda5a40db22a88fd41baed130945ae07d
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2023-01-15 (Sun, 15 Jan 2023)

  Changed paths:
    M Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp

  Log Message:
  -----------
  [WPE][GTK] Rename environment variable for turning off sandbox
https://bugs.webkit.org/show_bug.cgi?id=250232

Reviewed by Carlos Garcia Campos.

The name WEBKIT_FORCE_SANDBOX is really not scary enough to prevent
developers from using this permanently in their apps if something goes
wrong, or prevent users who don't know what a sandbox is from setting it
when it fixes something for them. This environment variable is really
dangerous and we should say that. So let's continue to respect
WEBKIT_FORCE_SANDBOX=1 to enable the sandbox, but if set to any other
value, print a warning that it will no longer be respected. A new
WEBKIT_DISABLE_SANDBOX_THIS_IS_DANGEROUS=1 environment variable is
introduced to allow disabling the sandbox exactly the same as ever,
since we really do need it for debugging purposes. Hopefully people will
think twice before using it for anything other than debugging.

* Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::isSandboxEnabled):
(WebKit::ProcessLauncher::launchProcess):

Canonical link: https://commits.webkit.org/258930@main