[webkit-changes] [WebKit/WebKit] 80a6a1: Potential Crash or Debug Assertion Fix - AudioNode...

Ahmad Saleem noreply at github.com
Sat Jan 14 11:20:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 80a6a175ed70f1aa4e4b8c2a06f9734d1a9e59c2
      https://github.com/WebKit/WebKit/commit/80a6a175ed70f1aa4e4b8c2a06f9734d1a9e59c2
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-01-14 (Sat, 14 Jan 2023)

  Changed paths:
    M Source/WebCore/Modules/webaudio/AudioNodeOutput.cpp

  Log Message:
  -----------
  Potential Crash or Debug Assertion Fix - AudioNodeOutput::enable() and AudioNodeOutput::disable() should not be reentered

Potential Crash or Debug Assertion Fix - AudioNodeOutput::enable() and AudioNodeOutput::disable() should not be reentered
https://bugs.webkit.org/show_bug.cgi?id=250277

Reviewed by Eric Carlson.

Merge - https://src.chromium.org/viewvc/blink?revision=181693&view=revision

This patch is to fix potential debug assertion fix where AudioNodeOutput::disable() can be reentered
and in order to avoid re-entry, this patch moves m_isEnabled place. Similar is done for
AudioNodeOutput::enable() to avoid re-entry.

* Source/WebCore/Modules/webaudio/AudioNodeOutput.cpp:
(AudioNodeOutput::disable): move m_isEnabled above 'for' loop
(AudioNodeOutput::enable): Ditto

Canonical link: https://commits.webkit.org/258919@main




More information about the webkit-changes mailing list