[webkit-changes] [WebKit/WebKit] db6a17: [IFC] Move lineNeedsTrailingEllipsis from InlineFo...

Alan Baradlay noreply at github.com
Sat Jan 14 07:50:14 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db6a17418ea9f1c79a3bbeb5851654ccf8ad5b0c
      https://github.com/WebKit/WebKit/commit/db6a17418ea9f1c79a3bbeb5851654ccf8ad5b0c
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-01-14 (Sat, 14 Jan 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  [IFC] Move lineNeedsTrailingEllipsis from InlineFormattingContext to LineBuilder
https://bugs.webkit.org/show_bug.cgi?id=250583

Reviewed by Antti Koivisto.

LineBuilder has all the information to figure out whether the line needs trailing ellipsis.
(So we should not let InlineFormattingContext::lineLayout post-mutate LineContent::lineNeedsTrailingEllipsis bit).

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):

Canonical link: https://commits.webkit.org/258915@main




More information about the webkit-changes mailing list