[webkit-changes] [WebKit/WebKit] e70da5: Move :dir()/:lang() pseudo-class tests to WPT

Tim Nguyen noreply at github.com
Fri Jan 13 19:36:18 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e70da52026c433c734b089428cf7147db51c5be0
      https://github.com/WebKit/WebKit/commit/e70da52026c433c734b089428cf7147db51c5be0
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-01-13 (Fri, 13 Jan 2023)

  Changed paths:
    R LayoutTests/fast/css/dir-pseudo-container-query-expected.html
    R LayoutTests/fast/css/dir-pseudo-container-query-invalidation-expected.html
    R LayoutTests/fast/css/dir-pseudo-container-query-invalidation.html
    R LayoutTests/fast/css/dir-pseudo-container-query.html
    R LayoutTests/fast/css/lang-pseudo-container-query-document-element-invalidation-expected.html
    R LayoutTests/fast/css/lang-pseudo-container-query-document-element-invalidation.html
    R LayoutTests/fast/css/lang-pseudo-container-query-invalidation-expected.html
    R LayoutTests/fast/css/lang-pseudo-container-query-invalidation-xhtml-expected.html
    R LayoutTests/fast/css/lang-pseudo-container-query-invalidation-xhtml.xhtml
    R LayoutTests/fast/css/lang-pseudo-container-query-invalidation.html
    R LayoutTests/fast/css/lang-pseudo-container-query-multiple-document-elements-invalidation-expected.html
    R LayoutTests/fast/css/lang-pseudo-container-query-multiple-document-elements-invalidation.html
    R LayoutTests/fast/css/lang-pseudo-disconnected-expected.txt
    R LayoutTests/fast/css/lang-pseudo-disconnected.html
    R LayoutTests/fast/css/lang-selector-empty-attribute-expected.txt
    R LayoutTests/fast/css/lang-selector-empty-attribute.xhtml
    R LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/lang-pseudo-class-across-shadow-boundaries-expected.html
    R LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/lang-pseudo-class-across-shadow-boundaries-ref.html
    R LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/lang-pseudo-class-across-shadow-boundaries.html
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-in-has-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-in-has.html
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-across-shadow-boundaries-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-across-shadow-boundaries-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-across-shadow-boundaries.html
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-disconnected-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-disconnected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-empty-attribute-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-empty-attribute.xhtml
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/dir-pseudo-class-in-has-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/dir-pseudo-class-in-has.html
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-document-element-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-document-element.html
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-multiple-document-elements-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-multiple-document-elements.html
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-xhtml-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-xhtml.xhtml
    A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has.html

  Log Message:
  -----------
  Move :dir()/:lang() pseudo-class tests to WPT
https://bugs.webkit.org/show_bug.cgi?id=250602
rdar://104245215

Reviewed by Simon Fraser.

They're useful tests, and it would be nice to have for Interop 2023.

- Renamed the tests to match naming in respective folders
- Use the common ref-filled-green-100px-square.xht upstream file in <link rel="match"> to avoid duplication
- Used testharness.js for some :lang() tests.
- Also moved 2 :lang() tests that were in css/css-pseudo into css/selectors

* LayoutTests/fast/css/dir-pseudo-container-query-expected.html: Removed.
* LayoutTests/fast/css/dir-pseudo-container-query-invalidation-expected.html: Removed.
* LayoutTests/fast/css/lang-pseudo-container-query-document-element-invalidation-expected.html: Removed.
* LayoutTests/fast/css/lang-pseudo-container-query-invalidation-expected.html: Removed.
* LayoutTests/fast/css/lang-pseudo-container-query-invalidation-xhtml-expected.html: Removed.
* LayoutTests/fast/css/lang-pseudo-container-query-multiple-document-elements-invalidation-expected.html: Removed.
* LayoutTests/fast/css/lang-pseudo-disconnected-expected.txt: Removed.
* LayoutTests/fast/css/lang-pseudo-disconnected.html: Removed.
* LayoutTests/fast/css/lang-selector-empty-attribute-expected.txt: Removed.
* LayoutTests/fast/css/lang-selector-empty-attribute.xhtml: Removed.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-in-has-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-in-has.html: Renamed from LayoutTests/fast/css/dir-pseudo-container-query.html.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-across-shadow-boundaries-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/lang-pseudo-class-across-shadow-boundaries-expected.html.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-across-shadow-boundaries-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/lang-pseudo-class-across-shadow-boundaries-ref.html.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-across-shadow-boundaries.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/lang-pseudo-class-across-shadow-boundaries.html.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-disconnected-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-disconnected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-empty-attribute-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/i18n/lang-pseudo-class-empty-attribute.xhtml: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/dir-pseudo-class-in-has-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/dir-pseudo-class-in-has.html: Renamed from LayoutTests/fast/css/dir-pseudo-container-query-invalidation.html.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-document-element-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-document-element.html: Renamed from LayoutTests/fast/css/lang-pseudo-container-query-document-element-invalidation.html.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-multiple-document-elements-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-multiple-document-elements.html: Renamed from LayoutTests/fast/css/lang-pseudo-container-query-multiple-document-elements-invalidation.html.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-xhtml-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has-xhtml.xhtml: Renamed from LayoutTests/fast/css/lang-pseudo-container-query-invalidation-xhtml.xhtml.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/lang-pseudo-class-in-has.html: Renamed from LayoutTests/fast/css/lang-pseudo-container-query-invalidation.html.

Canonical link: https://commits.webkit.org/258903@main




More information about the webkit-changes mailing list