[webkit-changes] [WebKit/WebKit] ee7192: REGRESSION(258448 at main): [GTK] Missing header with...

Manuel A. Fernandez Montecelo noreply at github.com
Fri Jan 13 14:35:54 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee71929690ce7a8a1b4f8fcca7218f3823854ac9
      https://github.com/WebKit/WebKit/commit/ee71929690ce7a8a1b4f8fcca7218f3823854ac9
  Author: Manuel A. Fernandez Montecelo <mafm at igalia.com>
  Date:   2023-01-13 (Fri, 13 Jan 2023)

  Changed paths:
    M Tools/TestWebKitAPI/glib/CMakeLists.txt

  Log Message:
  -----------
  REGRESSION(258448 at main): [GTK] Missing header with libwebrtc (USE_GSTREAMER_WEBRTC=FALSE)
https://bugs.webkit.org/show_bug.cgi?id=250573

Reviewed by Adrian Perez de Castro.

When using libwebrtc (USE_GSTREAMER_WEBRTC=FALSE) since commit
9def6e6f0258ddd9171d32bec2fffb684dbc7b8b, there's a compiler error:

---------
In file included from /home/build/WebKit/Source/WebKit/UIProcess/WebPreferences.h:33,
                 from /home/build/WebKit/Source/WebKit/UIProcess/API/glib/WebKitSettingsPrivate.h:31,
                 from /home/build/WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:23:
/home/build/WebKit/WebKitBuild/Release/WebCore/PrivateHeaders/WebCore/LibWebRTCProvider.h:37:10: fatal error: webrtc/api/peer_connection_interface.h: No such file or directory
   37 | #include <webrtc/api/peer_connection_interface.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
----------

This adds the necessary directories search for a successful
compilation.

* Tools/TestWebKitAPI/glib/CMakeLists.txt:

Canonical link: https://commits.webkit.org/258892@main




More information about the webkit-changes mailing list